GH1169 Improve parameter types for DataFrame.pct_change and Series.pct_change
#1194
Conversation
yangdanny97
changed the title
DataFrame.pct_change and Series.pct_changeDataFrame.pct_change and Series.pct_change
Dr-Irv
left a comment
Dr-Irv
left a comment
There was a problem hiding this comment.
Can you also add tests for the various arguments in test_frame.py:test_dataframe_pct_change() ?
Dr-Irv
left a comment
Dr-Irv
left a comment
There was a problem hiding this comment.
can you also add tests for Series.pct_change() in test_series.py ?
Use the check(assert_type(... pattern
|
I had to change the return type of Based on the docs, the output seems to be a series of floats, but @Dr-Irv thoughts? |
You did the right thing. |
3 participants
This PR does the following for the two functions in the title:
replace kwargs with keyword-only parameters for
pct_changebased on parameters fromshiftreplace
...w/ simple defaults when applicable based on docs: https://pandas.pydata.org/docs/reference/api/pandas.Series.pct_change.htmlmake
fill_methodforSeries.pct_changebeNone, just likeDataFrame.pct_changesince all other values are deprecatedCloses type
kwargsinpct_changeaccording to params inshift#1169Tests added: Please use
assert_type()to assert the type of any return valuecc @MarcoGorelli should these have tests? they're not overloaded so I'm not sure if it's necessary